TW-2169 added avatar and name for sender messages in web #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledNjim
requested review from
hoangdat,
dab246,
nqhhdev and
tddang-linagora
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2177 |
hoangdat
reviewed
Dec 9, 2024
hoangdat
reviewed
Dec 9, 2024
lib/pages/chat/events/message/message_content_with_timestamp_builder.dart
Outdated
Show resolved
Hide resolved
|
can you write widget test for this? |
hoangdat
reviewed
Dec 9, 2024
KhaledNjim
force-pushed
the
TW-2169_Update_chat_screen_ui
branch
from
ba7a6e9 to
a99bec9
Compare
nqhhdev
approved these changes
Dec 10, 2024
|
yeah, try to write test |
hoangdat
reviewed
Dec 12, 2024
hoangdat
reviewed
Dec 12, 2024
hoangdat
reviewed
Dec 12, 2024
KhaledNjim
force-pushed
the
TW-2169_Update_chat_screen_ui
branch
from
3037c47 to
160b24a
Compare
|
The widget test I added passes, but flutter analyze fails because the generated mock for User has an invalid implementation of the operator ==. It uses a parameter of type dynamic instead of Object
|
|
Merged in SDK, please rebase and squash commits we will review again |
KhaledNjim
force-pushed
the
TW-2169_Update_chat_screen_ui
branch
from
bc3fe59 to
6cbdae8
Compare
hoangdat
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Impact description
Added avatar and username for sent messages/images inside a chat
Test recommendations
Recommendations for how to test this, or anything else you are worried about?
Pre-merge
Resolved
Attach screenshots or videos demonstrating the changes