Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] PR for diff of DANDI vs. LINC #15

Closed
wants to merge 47 commits into from

Conversation

aaronkanzer
Copy link

Moves dandi#191 into LINC repo

Cc @kabilar

satra and others added 30 commits February 23, 2024 13:56
allow HEAD requests from different origins.
This silences the warning about using Node 16.
Add CI for terraform linting/validation
We'll want to remove these in a follow-up PR after
applying.
Deploy `dandidav` service to Heroku
Remove import blocks in webdav.tf
Neither of these are needed anymore now that we
are deploying by pushing directly to Heroku
Disable Rust buildpack and dyno-metadata feature
Add bucket policy statement for embargoed objects
Using just `heroku-community/cli` results in subsequent Terraform plans wanting to change it to the full URL.
Use a trailing dot for AWS ACM validation record
Remove trailing dot for ACM CNAME entry
Revert "Remove trailing dot for ACM CNAME entry"
mvandenburgh and others added 17 commits April 17, 2024 15:25
Give Heroku user `s3:PutObjectTagging` permission
Specify developer email list as env var
Allow PutObjectTagging for both production and staging buckets
Add `s3:PutObjectTagging` permission to sponsored bucket
This should allow terraform cloud to authenticate with AWS via a direct
trust relationship instead of relying on a manual token placed in the
environment variable of TFC.

See
https://developer.hashicorp.com/terraform/cloud-docs/workspaces/dynamic-provider-credentials#how-dynamic-credentials-work
for documentation on how the dynamic credential system works.
We recently upgraded our Heroku Postgres DB. This involved provisioning
a new DB instance, which put our Terraform state out of sync.
This has been applied and can now  be removed.
Scope trailing delete policy to `blobs` prefix only
@kabilar
Copy link
Member

kabilar commented Oct 31, 2024

Hi @aaronkanzer, perhaps we want this diff in the other direction from master into dandi-oct-diff? This will show all the changes that are in the LINC fork but not in DANDI. See #16.

@aaronkanzer
Copy link
Author

Thanks @kabilar -- closing in favor of #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants