Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements #316

Merged
merged 25 commits into from
Sep 27, 2024
Merged

Test improvements #316

merged 25 commits into from
Sep 27, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 15, 2023

This PR (required for #313):

  • refactors tests to split them into more files so they need to be annotated less when PIL is not available
  • rewrites the unittest-style assertions to regular assertions (since pytest is being used to run things)
  • rewrites the unittest-style tests to pytest-style functions (and pytest-style fixtures)
  • parametrizes tests to get rid of redundant code

@akx akx force-pushed the test-improvements branch from 3489991 to c37646f Compare February 15, 2023 15:23
@akx akx marked this pull request as draft February 15, 2023 15:24
@akx akx marked this pull request as ready for review February 16, 2023 18:17
@bartTC bartTC self-assigned this Aug 13, 2024
@bartTC bartTC mentioned this pull request Aug 13, 2024
@akx
Copy link
Contributor Author

akx commented Sep 26, 2024

@maribedran @bartTC I can rebase this cleanly - let me know on what...

@maribedran
Copy link
Contributor

Thanks, @akx ! I already merged you changes to #370 .

@maribedran maribedran merged commit 5405643 into lincolnloop:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants