Fix instanceof checks for a cross-realm scenario #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
The current
getRenderProperties()
implementation is nice, but it fails when a JS-code callingJsBarcode()
and a target DOM element belong to different realms (= windows).Yep, it is the real case in our internal codebase. :)
I have improved the implementation slightly by using explicit references to the appropriate classes instead of implicit global references.
Links with info:
instanceof
problem is unclear to you.)