Upgrade Gradle to 7.1 #3639
Merged
Upgrade Gradle to 7.1 #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Gradle 7.1 has been released. https://docs.gradle.org/7.1/release-notes.html Modifications: - Add an explicit dependency for implicit dependency between sourcesJar and generated sources. Many warnings similar to the following messages produced while building projects. See https://docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency ``` Execution optimizations have been disabled for task ':grpc:generateProto' to ensure correctness due to the following reasons: - Gradle detected a problem with the following location: '/Users/ikhun/src/armeria/grpc/gen-src/main'. Reason: Task ':grpc:sourcesJar' uses this output of task ':grpc:generateProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency for more details about this problem. - Gradle detected a problem with the following location: '/Users/ikhun/src/armeria/grpc/gen-src/main/resources/META-INF/armeria/grpc/armeria-main.dsc'. Reason: Task ':grpc:sourcesJar' uses this output of task ':grpc:generateProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency for more details about this problem. ``` - Add `kotlin` flag and dedupe Kotlin configurations - Remove `jcenter()` which has been deprecated - Replace `mainClassName` witth `mainClass.set()` - Upgrade groovy-xml from 2.5.12 -> 3.0.5 - Specify the default `DuplicatesStrategy` to `EXCLUDE` - The duplicated files raised error while build projects Result: Bump Gradle version from 6.8.3 to 7.1
Wouldn't this conflict with our version properties files? |
There are some resource files that conflict. version properties are also included. I thought |
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
============================================
+ Coverage 73.82% 73.95% +0.13%
- Complexity 14421 14545 +124
============================================
Files 1265 1266 +1
Lines 54985 55380 +395
Branches 7027 7114 +87
============================================
+ Hits 40591 40956 +365
+ Misses 10812 10806 -6
- Partials 3582 3618 +36
Continue to review full report at Codecov.
|
|
Looks like we still have some warnings left to address:
But.. can we just disable this warning at all? Our project is not that large so this optimization warning doesn't really matter to us at the moment. |
Unfortunately, it seems like there is no such option only for disabling this implicit dependency warning. |
|
Opened a PR for gradle-scalafmt to clean up the warning messages. alenkacz/gradle-scalafmt#43 |
trustin
reviewed
Jun 21, 2021
| @@ -0,0 +1,35 @@ | |||
| configure(projectsWithFlags('kotlin')) { | |||
trustin
reviewed
Jun 21, 2021
ikhoon
added a commit
to ikhoon/gradle-scripts
that referenced
this pull request
Jun 21, 2021
heowc
pushed a commit
to heowc/armeria
that referenced
this pull request
Jun 24, 2021
Motivation: Gradle 7.1 has been released. https://docs.gradle.org/7.1/release-notes.html Modifications: - Add an explicit dependency for implicit dependency between sourcesJar and generated sources. Many warnings similar to the following messages produced while building projects. See https://docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency ``` Execution optimizations have been disabled for task ':grpc:generateProto' to ensure correctness due to the following reasons: - Gradle detected a problem with the following location: '/Users/ikhun/src/armeria/grpc/gen-src/main'. Reason: Task ':grpc:sourcesJar' uses this output of task ':grpc:generateProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency for more details about this problem. - Gradle detected a problem with the following location: '/Users/ikhun/src/armeria/grpc/gen-src/main/resources/META-INF/armeria/grpc/armeria-main.dsc'. Reason: Task ':grpc:sourcesJar' uses this output of task ':grpc:generateProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency for more details about this problem. ``` - Add `kotlin` flag and dedupe Kotlin configurations - Remove `jcenter()` which has been deprecated - Replace `mainClassName` witth `mainClass.set()` - Upgrade groovy-xml from 2.5.12 -> 3.0.5 - Specify the default `DuplicatesStrategy` to `EXCLUDE` - The duplicated files raised error while build projects Result: Bump Gradle version from 6.8.3 to 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Gradle 7.1 has been released. https://docs.gradle.org/7.1/release-notes.html
Modifications:
and generated sources.
Many warnings similar to the following messages produced while building
projects. See https://docs.gradle.org/7.1/userguide/validation_problems.html#implicit_dependency
kotlinflag and dedupe Kotlin configurationsjcenter()which has been deprecatedmainClassNamewitthmainClass.set()DuplicatesStrategytoEXCLUDEResult:
Bump Gradle version from 6.8.3 to 7.1