Improve the server shutdown process #1104
Open
+122
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When a Central Dogma server stops, it first closes `GitRepository` and other resources internally. The shutdown process does not respect `GracefulShutdownTimeout` but immediately closes them. As a result, inflight requests fail with `ShuttingDownException` even though they were received before the shutdown process started. To gracefully shut down the server, I propose closing the Armeria server first. During the Armeria shutdown process, it will wait for requests to be finished during the GracefulShutdownTimeout. Motifications: - Close the server first and then shut down other resources. - Configure Armeria `GracefulShutdown` to fail long-running requests with `ShuttingdownException` - Fix `HttpApiExceptionHandler` to return 304 Not Modified for watch requests after the graceful shutdown timeout. Result: The Central Dogma server gracefully terminates requests while respecting `GracefulShutdownTimeout`. # Conflicts: # dependencies.toml
jrhee17
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a Central Dogma server stops, it first closes
GitRepositoryand other resources internally. The shutdown process does not respectGracefulShutdownTimeoutbut immediately closes them. As a result, inflight requests fail withShuttingDownExceptioneven though they were received before the shutdown process started.To gracefully shut down the server, I propose closing the Armeria server first. During the Armeria shutdown process, it will wait for requests to be finished during the GracefulShutdownTimeout.
Motifications:
GracefulShutdownto fail long-running requests withShuttingdownExceptionHttpApiExceptionHandlerto return 304 Not Modified for watch requests after the graceful shutdown timeout.Result:
The Central Dogma server gracefully terminates requests while respecting
GracefulShutdownTimeout.