-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace commitDate format to ISO8601 #176
base: main
Are you sure you want to change the base?
Conversation
@palindrom615 May I know what usability is improved? For humans, |
@ikhoon I see. that should not break anything. WDYT about adding
It saves some codes for parsing dateformat. For instance, jib uses iso8601.
|
Sounds good. I think we can keep both of them for a while and then deprecate and remove Would you be interested in sending a PR to Armeria as well when this PR is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @palindrom615!
sure I can 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea. Thanks, @palindrom615 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @palindrom615!
@jrhee17 Do you mind reviewing this PR? >_< |
According to git document, git is using unique datetime format with
--iso
option.Replacing it with strict ISO8601 format will improve usability.