Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace crypto implementation with stronger key generation method #158

Merged
merged 23 commits into from
Dec 6, 2023
Merged

Replace crypto implementation with stronger key generation method #158

merged 23 commits into from
Dec 6, 2023

Conversation

YkSix
Copy link
Contributor

@YkSix YkSix commented Dec 5, 2023

  1. Replace weak crypto implementation
  2. Bump LINE SDK version to 5.10.0

YkSix added 22 commits December 5, 2023 09:59
@YkSix
dev: rename StringCipher.java to StringCipherDeprecated.java
c339e3e 
Signed-off-by: EricLu <[email protected]>
@YkSix
dev: add interface StringCipher
512d78f 
Signed-off-by: EricLu <[email protected]>
@YkSix
dev: make class StringCipherDeprecated implement StringCipher interface
9bec8ff 
Signed-off-by: EricLu <[email protected]>
@YkSix
dev: change the type of EncryptorHolder#ENCRYPTOR to StringCipher int…
f415755 
…erface

Signed-off-by: EricLu <[email protected]>
@YkSix
dev: create empty class: StringAesCipher.kt
8ca87fb 
Signed-off-by: EricLu <[email protected]>
@YkSix
dev: fix wrong startIndex of keyBytes array although the values are t…
36bd34e 
…he same
@YkSix
dev: implement StringAesCipher; encrypt data using a secret key store…
8a3c573 
…d in AndroidKeyStore

class for implementation reference:
 PayAesCipher.kt class in pay-base module in LINE App
@YkSix
dev: move class SecretKeys to a new file and kotlinize it
61ec712
@YkSix
dev: change property type of CipherData to ByteArray
1771435
@YkSix
dev: calculate HMAC value and store it in CipherData
5536deb
@YkSix
dev: verify HMAC value before proceeding with the decryption
d69d5c4
@YkSix
dev: rename to verifyHmacValue, throw Exception if the HMAC values do…
6f74696 
…n't match
@YkSix
dev: make StringAesCipher a thread-safe class, wrap code in synchroni…
3bfe42a 
…zed block
@YkSix
dev: add PURPOSE_SIGN in IntegrityKey
ec80a29 
PURPOSE_SIGN
- signing or generating a MAC

PURPOSE_VERIFY
- signature or MAC verification
@YkSix
dev: switch to new AES crypto implementation
6a77a22
@YkSix
Revert "dev: move class SecretKeys to a new file and kotlinize it"
fb4af3b 
This reverts commit eb2c46e.
@YkSix
dev: modify test
b29e888
@YkSix
dev: rename functions to encodeToBase64String and decodeFromBase64String
3089706
@YkSix
dev: use joinToString in encodeToBase64String
dcad1d8
@YkSix
dev: add more comments
5701fab
@YkSix
dev: add @deprecated annotation
9240c23
@YkSix
chore: update version to 5.10.0
de0863f
plateaukao
plateaukao reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsairene
tsairene approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@tsairene tsairene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

line-sdk/build.gradle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also help to update versionCode to 5_10_00 on line 18.

plateaukao
plateaukao approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plateaukao plateaukao merged commit aefcdaa into line:master Dec 6, 2023
@YkSix YkSix changed the title Replace weak crypto implementation Replace crypto implementation with stronger key generation method Dec 8, 2023
@YkSix YkSix deleted the fix_weak_crypto_impl branch May 7, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plateaukao plateaukao plateaukao approved these changes

@tsairene tsairene tsairene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YkSix @plateaukao @tsairene