Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LINE SDK version in sample app to v5.10.1 #169

Merged
merged 2 commits into from
May 20, 2024

Conversation

YkSix
Copy link
Contributor

@YkSix YkSix commented May 20, 2024

  1. improve version extraction in GitHub Actions
  2. bump the LINE SDK version used in sample app to v5.10.1

YkSix added 2 commits May 20, 2024 10:32
Use awk to reliably extract the last non-empty line from the output of the
gradlew -q printVersionName command. This change ensures that the version
name is accurately captured, even when preceding lines contain unrelated
installation or license acceptance messages.

This modification enhances the robustness of the Retrieve Version step by
focusing on the final line, which is expected to be the version number.
@YkSix YkSix requested review from plateaukao and tsairene May 20, 2024 03:02
Copy link
Member

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YkSix YkSix merged commit c0759a5 into line:master May 20, 2024
3 checks passed
@YkSix YkSix deleted the bump_sdk_version_in_sample_app branch May 20, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants