[Enhancements] Migrating IP to Country database to IPinfo #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should approve this PR, can fix your problem with the outdated database. |
|
Thank you @kleper. I have emailed the maintainer of the project as well. |
|
Is this project unmanteined? |
|
I am not sure if my fork itself has been stale. If you take a look at the code, integrating our IP to Country database is not very complicated. For the update mechanism, we support direct download via a storage URI with only a token. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The existing IP-to-country database solution does not provide daily updates and has compromised accuracy. IPinfo's IP-to-country database offers full accuracy and is updated daily.
Although the current database is only updated biweekly, our project downloads the database daily.
Instead of the current setup, which involves unzipping the geolocation database, we can directly download and use IPinfo's MMDB database.
I have forked the repository and migrated the code references to IPinfo. The IPinfo free IP-to-country database can be used under the CC-BY-SA 4.0 license.