Introduce the tombstone for RocksDb
#3302
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The tombstone problem has emerged as a problem for
RocksDb
. We therefore introduce the test here for this store. We also do some corrections and simplification to the testing framework.Proposal
We propose the following changes:
Besides, there are a number of changes for the tests:
MemoryContext::new_for_testing
function since the calls always took the same arguments.Debug
in the error type since it was not used.Test Plan
The CI is the object of those changes.
Release Plan
Not relevant to TestNet / DevNet.
Links
None.