Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the tombstone for RocksDb #3302

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MathieuDutSik
Copy link
Contributor

Motivation

The tombstone problem has emerged as a problem for RocksDb. We therefore introduce the test here for this store. We also do some corrections and simplification to the testing framework.

Proposal

We propose the following changes:

  • Add the testing of read keys from the store as test.
  • Iterate the reading of the keys from the store to see the evolution of the performance.
  • Introduce the test for RocksDb.

Besides, there are a number of changes for the tests:

  • Simplification of the MemoryContext::new_for_testing function since the calls always took the same arguments.
  • Elimination of requirement for Debug in the error type since it was not used.
  • Put the creation of the testing store in the benchmark code.

Test Plan

The CI is the object of those changes.

Release Plan

Not relevant to TestNet / DevNet.

Links

None.

@MathieuDutSik MathieuDutSik marked this pull request as ready for review February 12, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant