Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update for next 15 #2073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: update for next 15 #2073

wants to merge 1 commit into from

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Oct 29, 2024 4:10pm

@timofei-iatsenko timofei-iatsenko mentioned this pull request Oct 29, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.68 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@timofei-iatsenko timofei-iatsenko changed the title examples: update for next 15 docs: update for next 15 Oct 29, 2024
@andrii-bodnar andrii-bodnar modified the milestone: v5 Oct 30, 2024
@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review October 31, 2024 12:17
Copystrike
Copystrike reviewed Nov 4, 2024
View reviewed changes
examples/nextjs-swc/src/initLingui.tsx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since initLingui.tsx has no JSX, renaming it to initLingui.ts would clarify it's a utility function and signal to people to place it in a /lib folder instead of /components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Copystrike Copystrike Copystrike left review comments

@Trosterud Trosterud Trosterud left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timofei-iatsenko @Trosterud @Copystrike @andrii-bodnar