Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add softcapping to preference based fused linear #437

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add softcapping to preference based fused linear #437

wants to merge 14 commits into from

Conversation

ryankert01
Copy link
Contributor

@ryankert01 ryankert01 commented Dec 8, 2024 •
edited
Loading

Summary

close #426

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

austin362667
austin362667 reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@austin362667 austin362667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind move test/transformers/test_fused_linear_preference.py to test/chunked_loss ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin362667 austin362667 austin362667 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PreferenceBase with Softcapping?
2 participants
@ryankert01 @austin362667