Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the on-paper form of the RoPE kernel from RoFormer.
This implementation does not support optional value input, unlike the HuggingFace RoFormer RoPE implementation.
Details
The code is adapted from Liger Kernel's RoPE implementation.
In the current Liger Kernel's RoPE implementation, the head is divided into left and right parts for computation:
Corresponds to the vector-vector multiplication-addition form:
To obtain the on-paper form of RoPE, the head is instead divided into even-indexed and odd-indexed parts for computation:
$y_{even} = x_{even} * cos - x_{odd} * sin$
$y_{odd} = x_{odd} * cos + x_{even} * sin$
Corresponds to the vector-vector multiplication-addition form:
Testing Done
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence