Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KTO Loss #475

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add KTO Loss #475

wants to merge 7 commits into from

Conversation

hebiao064
Copy link
Collaborator

@hebiao064 hebiao064 commented Dec 13, 2024

Summary

Close KTO Item of the Roadmap: #371

Implements the Kahneman-Tversky Optimization (KTO) loss function.

KTO Loss Function

For a policy π compared to a reference policy π₀:

When y is chosen:

$L_{KTO} = 1 - \sigma(\beta \cdot (\log[\frac{\pi(x)}{\pi_0(x)}] - KL(\pi||\pi_0)_y))$

When y is rejected:

$L_{KTO} = 1 - \sigma(\beta \cdot (KL(\pi||\pi_0)_y - \log[\frac{\pi(x)}{\pi_0(x)}]))$

where:

  • σ is the sigmoid function
  • β is a temperature parameter
  • KL(π||π₀)_y is the KL divergence threshold for action y

Intuition

KTO loss is inspired by prospect theory from behavioral economics, which models how humans make decisions under uncertainty.

The loss function is asymmetric, treating gains and losses differently, similar to
human decision-making patterns.

Screenshot 2024-12-13 at 11 10 39 AM

Credit by: https://www.youtube.com/watch?v=nSrj1J6ODoM&t=422s

Benchmark Result

Memory:

Screenshot 2024-12-13 at 10 55 03 AM

Speed:
Screenshot 2024-12-13 at 10 54 12 AM

Key Changes

  • Implemented LigerFusedLinearKTOLoss class
  • Added LigerFusedLinearKTOFunction for the core KTO computation
  • Created comprehensive test suite in test_kto_loss.py
  • Added reference implementation (HFKTOLoss) based on Hugging Face's implementation

Reference

Testing Done

Test is passing now:
pytest test/chunked_loss/test_kto_loss.py

  • Parameterized tests covering various configurations:
    • Different batch sizes, sequence lengths, hidden dims, and vocab sizes
    • Multiple data types (bfloat16, float32)
    • Bias and reference bias variations
    • Different ignore indices and beta values
  • Correctness tests comparing against reference implementation
  • Gradient checking and backward pass verification
  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@hebiao064 hebiao064 marked this pull request as ready for review December 13, 2024 01:41
Copy link
Collaborator

@ByronHsu ByronHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a brief look, I am not very familiar with KTO math but why do we not have KL_log_probs but original HF has https://github.com/huggingface/trl/blob/cd7156fb34ddf9a8c04fcd640a4067933461d44e/trl/trainer/kto_trainer.py#L1121. We also need to be careful about scaling. Seems in original HF, kto_loss returns an unreduced version, but we probably need to reduce as mean. cc @shivam15s

@hebiao064
Copy link
Collaborator Author

Take a brief look, I am not very familiar with KTO math but why do we not have KL_log_probs but original HF has https://github.com/huggingface/trl/blob/cd7156fb34ddf9a8c04fcd640a4067933461d44e/trl/trainer/kto_trainer.py#L1121. We also need to be careful about scaling. Seems in original HF, kto_loss returns an unreduced version, but we probably need to reduce as mean. cc @shivam15s

About KL, I'll take a further look in trl about how to support that.

About reduce, HF did averaged it here: loss = losses.nanmean()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants