Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish for Scala 2.12 #14

Closed
nightscape opened this issue Apr 24, 2020 · 8 comments · Fixed by #16
Closed

Publish for Scala 2.12 #14

nightscape opened this issue Apr 24, 2020 · 8 comments · Fixed by #16
Assignees
Labels
enhancement New feature or request

Comments

@nightscape
Copy link

Hi all!

Would it be possible to cross-publish this project to Scala 2.12?
I'm trying to upgrade Microsoft's MMLSpark to Scala 2.12, but I'm currently blocked by isolation-forest having only a 2.11 build.
There seem to be a few options to do this, e.g. https://github.com/prokod/gradle-crossbuild-scala or https://github.com/ADTRAN/gradle-scala-multiversion-plugin

Thanks a lot!

@jverbus
Copy link
Contributor

jverbus commented Apr 28, 2020

@nightscape, thanks for reaching out!

The automated release library I'm using doesn't current support building and publishing multiple artifacts using different dependencies under the same release version. I filed a request for this a while ago and they are working on it.

mockito/shipkit#858

I can manually build an artifact using 2.12 for the most recent isolation forest version and publish it to JCenter and Maven Central. This week is pretty packed for me, but I will aim to do this the following week.

@nightscape
Copy link
Author

In case your interested I could create an SBT build as well, but you're probably more familiar with Gradle and have therefore decided to use it here.

@jverbus
Copy link
Contributor

jverbus commented Apr 28, 2020

Thanks for the offer, but we use Gradle internally at LinkedIn and would like to stick with it here.

@jverbus
Copy link
Contributor

jverbus commented May 27, 2020

Hey @nightscape, a new artifact built with Scala 2.12 is now available in Maven Central.

https://oss.sonatype.org/#nexus-search;quick~isolation-forest

<dependency>
  <groupId>com.linkedin.isolation-forest</groupId>
  <artifactId>isolation-forest_2.4.3_2.12</artifactId>
  <version>0.3.3</version>
</dependency>

@jverbus jverbus added the enhancement New feature or request label May 27, 2020
@jverbus jverbus closed this as completed May 27, 2020
@jverbus
Copy link
Contributor

jverbus commented May 27, 2020

@nightscape: Please let me know if this works for you. Thanks!

@nightscape
Copy link
Author

nightscape commented May 27, 2020

Hey @jverbus, thanks a lot!
It seems that the artifact is currently only in the LinkedIn Nexus repo at
https://oss.sonatype.org/service/local/repositories/comlinkedin-1736/content/
Does it maybe have to be released and promoted?

@jverbus
Copy link
Contributor

jverbus commented May 27, 2020

@nightscape: Yep, it needed to be released. It should now be available. Thanks!

@nightscape
Copy link
Author

I successfully pulled 1.0.0 for Scala 2.12. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants