Added Scala version selection via build parameter. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jverbus
force-pushed
the
gradle-scala-version
branch
from
da56920 to
5fb4333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the capability to specify the Scala build version using the build parameter scalaVersion. This will now allow us to build using Scala 2.12, which has been requested here: #14
Currently, only one build is released using Shipkit. Once Shipkit supports releasing multiple builds under the same version, we will automatically publish the artifacts from all builds. I submitted a request for this Shipkit enhancement a while back:
mockito/shipkit#858
In the meantime, I still want Travis CI to build multiple versions with Spark 2.3.0, Spark 2.4.2, Scala 2.11, Scala 2.12, etc. to verify they all build successfully. I modified the .travis.yml file to achieve this. The builds are done in parallel:
https://travis-ci.org/github/linkedin/isolation-forest/builds/691178714