feat(policy): Add http protocol configuration #13721
Open
+486
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
force-pushed
the
sfleen/protocol-detect-http1
branch
from
41cc8f5 to
7a18c94
Compare
olix0r
reviewed
Feb 27, 2025
| @@ -57,7 +63,7 @@ func serviceName(n string) string { | |||
|
|
|||
| func TestAppProtocolCalledByServiceTarget(t *testing.T) { | |||
| ctx := context.Background() | |||
| TestHelper.WithDataPlaneNamespace(ctx, "appprotocol-called-by-service-name-test", map[string]string{}, t, func(t *testing.T, appProtocolNs string) { | |||
| TestHelper.WithDataPlaneNamespace(ctx, "appProtocol-called-by-service-name-test", map[string]string{}, t, func(t *testing.T, appProtocolNs string) { | |||
There was a problem hiding this comment.
this is causing test failures--namespaces need to be lowercase
sfleen
force-pushed
the
sfleen/protocol-detect-http1
branch
from
7a18c94 to
485529d
Compare
This adds `"http"` and `"kubernetes.io/h2c"` as a valid values for service port `appProtocol`. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
sfleen/protocol-detect-http1
branch
from
485529d to
a096b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "http" and "kubernetes.io/h2c" as a valid values for service port appProtocol. Continuation of #13660.