Merge pull request #320 from sneakers-the-rat/fix-linkml-files-uris

Correct `linkml_files.URL_FOR` - add URL resolutiontests
linkml · Jun 14, 2024 · 34a30ee · 34a30ee
2 parents 49aecb2 + df1a56e
commit 34a30ee
Show file tree

Hide file tree

Showing 6 changed files with 157 additions and 53 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -50,7 +50,7 @@ jobs:
       #----------------------------------------------
       - name: Generate coverage results
         run: |
-          poetry run coverage run -m unittest discover
+          poetry run coverage run -m pytest
           poetry run coverage xml
           poetry run coverage report -m
 

diff --git a/linkml_runtime/linkml_model/linkml_files.py b/linkml_runtime/linkml_model/linkml_files.py
@@ -143,7 +143,8 @@ def _build_loc(base: str, source: Source, fmt: Format) -> str:
 
 def URL_FOR(source: Source, fmt: Format) -> str:
     """ Return the URL to retrieve source in format """
-    return f"{LINKML_URL_BASE}{source.value}.{fmt.value}"
+    fmt_path: FormatPath = _Path.get(fmt.name)
+    return f"{LINKML_URL_BASE}{source.value}.{fmt_path.extension}"
 
 
 def LOCAL_PATH_FOR(source: Source, fmt: Format) -> str: