-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for object storage services gen2 #649
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d3043eb
Add support for OBJ gen2
zliang-akamai 46fb1a6
Fix test
zliang-akamai 52f36d2
Fix
zliang-akamai 5243c2b
gofumpt
zliang-akamai b40d63b
Add v2 functions and structs
zliang-akamai b3b6ec6
address comments
zliang-akamai efd91b9
Multiple test updates
zliang-akamai c781a84
Add V2 cert test
zliang-akamai 9c5ffe3
More tests for V2 functions and structs
zliang-akamai 7677de7
Sorted region capabilities
zliang-akamai 7fb70e4
Merge branch 'main' into zhiwei/obj-gen2
zliang-akamai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package linodego | ||
|
||
import "context" | ||
|
||
// NotificationType constants start with Notification and include all known Linode API Notification Types. | ||
type ObjectStorageEndpointType string | ||
|
||
// NotificationType constants represent the actions that cause a Notification. New types may be added in the future. | ||
const ( | ||
ObjectStorageEndpointE0 ObjectStorageEndpointType = "E0" | ||
ObjectStorageEndpointE1 ObjectStorageEndpointType = "E1" | ||
ObjectStorageEndpointE2 ObjectStorageEndpointType = "E2" | ||
ObjectStorageEndpointE3 ObjectStorageEndpointType = "E3" | ||
) | ||
|
||
// ObjectStorageEndpoint represents a linode object storage endpoint object | ||
type ObjectStorageEndpoint struct { | ||
Region string `json:"region"` | ||
S3Endpoint *string `json:"s3_endpoint"` | ||
EndpointType ObjectStorageEndpointType `json:"endpoint_type"` | ||
} | ||
|
||
// ListObjectStorageEndpoints lists all endpoints in all regions | ||
func (c *Client) ListObjectStorageEndpoints(ctx context.Context, opts *ListOptions) ([]ObjectStorageEndpoint, error) { | ||
return getPaginatedResults[ObjectStorageEndpoint](ctx, c, "object-storage/endpoints", opts) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's worth introducing a
ObjectStorageObjectACLConfigUpdateOptionsV2
struct for consistency and future-proofing, although it might be a bit redundant 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the API schema will stay the same for this set of options? Gen2 doesn't currently support the object-level ACL.