Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/workflow: Update make test commands and related workflows #657

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Jan 21, 2025

📝 Description

In efforts to unify test commands across all repository, the commands are refactored in Makefile. Refer to "How to Test" Section

Also related GHA workflow yamls have been updated with the latest commands

✔️ How to Test

  • Integration test: make test-int or make fixtures
  • Unit test: make test-unit
  • Smoke test: make test-smoke

ARGS changed to TEST_ARGS

Usage: make TEST_ARGS="-run TestNodeBalancer" fixtures

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner January 21, 2025 02:04
@ykim-akamai ykim-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team January 21, 2025 02:04
@ykim-akamai ykim-akamai added repo-ci-improvement for improvements in the repository or CI workflow in the changelog. testing for updates to the testing suite in the changelog. labels Jan 21, 2025
@@ -50,7 +50,7 @@ jobs:
python-version: '3.x'

- name: Install Python deps
run: pip3 install requests wheel boto3
run: pip3 install requests wheel boto3==1.35.99
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rolling back boto3 version to address report upload issue

Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykim-akamai ykim-akamai merged commit 7d14d5c into linode:main Jan 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo-ci-improvement for improvements in the repository or CI workflow in the changelog. testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants