-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9155] Add billing agreement checkbox for tax id #11563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report: ✅ |
hana-akamai
approved these changes
Jan 30, 2025
packages/manager/cypress/e2e/core/billing/billing-contact.spec.ts
Outdated
Show resolved
Hide resolved
...ngPanels/ContactInfoPanel/UpdateContactInformationForm/UpdateContactInformationForm.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Hana Xu <[email protected]>
Cloud Manager UI test results🎉 495 passing tests on test run #6 ↗︎
|
bnussman-akamai
approved these changes
Jan 31, 2025
Cloud Manager E2E
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
|
Run duration | 30m 46s |
Commit |
|
Committer | Jaalah Ramos |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
4
|
|
2
|
|
0
|
|
495
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Checkbox to confirm Tax ID update and submit to
/agreements
endpointChanges 🔄
billing_agreement: boolean
toAgreements
interfaceaccountAgreementsFactory
as wellTarget release date 🗓️
2/11
Preview 📷
Added legal privacy statement
![Screenshot 2025-01-29 at 8 10 42 PM](https://private-user-images.githubusercontent.com/125309814/407967060-4687f47d-d63c-41f5-aa88-598b281d2a9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNzE2MTAsIm5iZiI6MTczOTA3MTMxMCwicGF0aCI6Ii8xMjUzMDk4MTQvNDA3OTY3MDYwLTQ2ODdmNDdkLWQ2M2MtNDFmNS1hYTg4LTU5OGIyODFkMmE5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQwMzIxNTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02OTU1NjE2MmY1ZjUwMDY4NmEyYmU4MmQ0ZjlhZjNhNWRmOWY0NmUwYTgwZTY5NmI5YzgxYzkwMzcyMmU5NjdhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ZePcE9L_MIjG-5Nw_9nLki9BdMHg3D_g_gDZIN4D3c8)
video.mov
How to test 🧪
Prerequisites
Verification steps
Set country to United State
Ensure no tax id related information or checkbox renders
Change to a non-US country
Observe all tax id related information appears
Observe submit is disabled until you fill in a tax id and check the agreement
Observe POST for /agreements is correctly set to
true
Run and observe agreement is correct
If you try to set this to false, you should get:
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅