Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-9155] Add billing agreement checkbox for tax id #11563

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Jan 23, 2025

Description 📝

Checkbox to confirm Tax ID update and submit to /agreements endpoint

Changes 🔄

  • Add billing_agreement: boolean to Agreements interface
    • Add to accountAgreementsFactory as well
  • Add e2e test to ensure button is disabled until user checks agreement

Target release date 🗓️

2/11

Preview 📷

Added legal privacy statement
Screenshot 2025-01-29 at 8 10 42 PM

video.mov

How to test 🧪

Prerequisites

  • You must have dev/alpha access
  • You must have an actual tax id to see POST request (see ticket)

Verification steps

  • Set country to United State

  • Ensure no tax id related information or checkbox renders

  • Change to a non-US country

  • Observe all tax id related information appears

  • Observe submit is disabled until you fill in a tax id and check the agreement

  • Observe POST for /agreements is correctly set to true

  • Run and observe agreement is correct

curl -H "Authorization: Bearer <TOKEN>" --request GET \
     --url https://api.linode.com/v4/account/agreements \
     --header 'accept: application/json'

If you try to set this to false, you should get:

curl -H "Authorization: Bearer <TOKEN>" --request POST \
     --url https://api.linode.com/v4/account/agreements \
     --header 'accept: application/json' \
     --header 'content-type: application/json' \
     --data '{"billing_agreement":false}'

{"errors": [{"reason": "'billing_agreement' cannot be set to false. Please contact support if you need to reset the status of this agreement.", "field": "billing_agreement"}]}
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Jan 24, 2025
@jaalah-akamai jaalah-akamai marked this pull request as ready for review January 24, 2025 03:14
@jaalah-akamai jaalah-akamai requested review from a team as code owners January 24, 2025 03:14
@jaalah-akamai jaalah-akamai requested review from dmcintyr-akamai, hana-akamai, cpathipa, a team and jdamore-linode and removed request for a team January 24, 2025 03:14
Copy link

github-actions bot commented Jan 24, 2025

Coverage Report:
Base Coverage: 79.28%
Current Coverage: 79.28%

@hana-akamai hana-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Jan 30, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 495 passing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing495 Passing2 Skipped110m 11s

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 31, 2025
@jaalah-akamai jaalah-akamai merged commit c47ddd4 into linode:develop Feb 3, 2025
23 checks passed
Copy link

cypress bot commented Feb 3, 2025

Cloud Manager E2E    Run #7160

Run Properties:  status check passed Passed #7160  •  git commit c47ddd43ed: upcoming: [M3-9155] Add billing agreement checkbox for tax id (#11563)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7160
Run duration 30m 46s
Commit git commit c47ddd43ed: upcoming: [M3-9155] Add billing agreement checkbox for tax id (#11563)
Committer Jaalah Ramos
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 495
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants