refactor: [M3-9157] - TanStack Router Migration for Images Feature #11578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
M3-9157
branch
from
feff641 to
dc59eb7
Compare
abailly-akamai
changed the title
abailly-akamai
requested review from
bnussman-akamai and
coliu-akamai
and removed request for
a team
abailly-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
|
Coverage Report: ✅ |
abailly-akamai
force-pushed
the
M3-9157
branch
from
0a9b760 to
6d7c9ee
Compare
Cloud Manager UI test results🎉 494 passing tests on test run #9 ↗︎
|
coliu-akamai
approved these changes
Jan 31, 2025
| 'images-manual-order', | ||
| 'manual' | ||
| ); | ||
| preferenceKey: MANUAL_IMAGES_PREFERENCE_KEY, |
There was a problem hiding this comment.
Should we use MANUAL_IMAGES_ORDER_PREFERENCE_KEY instead? I see you have it defined in the constants but it isn't imported here. (not seeing any differences besides the preference key's name):
Comment on lines
-75
to
-78
| { | ||
| onClick: () => onCancelFailed?.(id), | ||
| title: 'Cancel', | ||
| }, |
There was a problem hiding this comment.
the onCancelFailed handler is defined in the Handlers interface - do we still need it?
bnussman-akamai
approved these changes
Feb 3, 2025
bnussman-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 14s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
495
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TanStack Router Migration for Images Feature
Overview 📝
routes/images/ImagesLandingto use TanStack Router hooksThe changes maintain existing functionality while providing better type safety and state management through the URL.
Preview 📷
No visual difference/regression should be experioenced as a result of this PR
How to test 🧪
Prerequisites
Verification steps
prod-test-019to test pagination since it has a large amount of imagesAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅