Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8372] - database migration event notification #11590

Conversation

mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Jan 30, 2025

Description 📝

DBaaS migrate event notification

Changes 🔄

List any change(s) relevant to the reviewer.

  • added a new states: 'Migrating', 'Migrated', that are displayed for the cluster
  • added an event notification under the bell icon with a message about the migration status

Target release date 🗓️

2/11/25

Preview 📷

Before After
Screenshot 2025-01-30 at 5 54 13 PM
Screenshot 2025-01-30 at 5 46 57 PM

How to test 🧪

Verification steps

(How to verify changes)

  • When the migration process starts, the database status will change to "Migrating", and a new event notification will appear under the bell icon indicating that the migration is in progress.

  • Once the migration is complete, the database status will change to "Migrated", and a new event notification will appear under the bell icon confirming that the migration is completed.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner January 30, 2025 16:55
@mpolotsk-akamai mpolotsk-akamai requested review from dwiley-akamai and hasyed-akamai and removed request for a team January 30, 2025 16:55
Copy link

github-actions bot commented Jan 30, 2025

Coverage Report:
Base Coverage: 79.28%
Current Coverage: 79.28%

@cpathipa cpathipa requested review from cpathipa and removed request for hasyed-akamai January 30, 2025 20:29
@cpathipa cpathipa added the DBaaS Relates to Database as a Service label Jan 30, 2025
@mpolotsk-akamai mpolotsk-akamai force-pushed the feature/UIE-8372-migrate-event-notification branch from 9db0cb1 to 2bcc070 Compare January 31, 2025 09:30
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 494 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing494 Passing2 Skipped103m 50s

@@ -33,6 +33,8 @@ export type DatabaseStatus =
| 'active'
| 'degraded'
| 'failed'
| 'migrating'
| 'migrated'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will a database be migrated?

Does it go from migrating ➡️ migrated ➡️ active?

Asking because this seems a bit unusual for a Linode product. Usually entities just transition back to active (or the equivalent to that) when they are done migrating / resizing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnussman-akamai , after a migration is completed, the migrated databases will be left in a read-only state by the tooling and automation that the migration team provides. The special state of the old database is "migrated", while the new database will be "running".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhh. I see. So this is for migrating from Legacy to Aiven?

My mistake. I thought this was for migrating a DBaaS cluster between different datacenters.

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality LGTM, Agreed with @bnussman-akamai it could be consistent with other events unless there is a requirement for the migrated status of databases.

@cpathipa cpathipa added the Approved Multiple approvals and ready to merge! label Jan 31, 2025
@cpathipa
Copy link
Contributor

cpathipa commented Feb 3, 2025

@mpolotsk-akamai Next planned release is 2/11, could you update the release section accordingly ?

@mpolotsk-akamai
Copy link
Contributor Author

@mpolotsk-akamai Next planned release is 2/11, could you update the release section accordingly ?

@cpathipa , updated.
Thanks!

@cpathipa cpathipa merged commit 17185cc into linode:develop Feb 3, 2025
23 checks passed
Copy link

cypress bot commented Feb 3, 2025

Cloud Manager E2E    Run #7164

Run Properties:  status check passed Passed #7164  •  git commit 17185ccef8: feat: [UIE-8372] - database migration event notification (#11590)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7164
Run duration 28m 10s
Commit git commit 17185ccef8: feat: [UIE-8372] - database migration event notification (#11590)
Committer mpolotsk-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 497
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants