-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-8372] - database migration event notification #11590
feat: [UIE-8372] - database migration event notification #11590
Conversation
Coverage Report: ✅ |
…or database migration
9db0cb1
to
2bcc070
Compare
Cloud Manager UI test results🎉 494 passing tests on test run #3 ↗︎
|
@@ -33,6 +33,8 @@ export type DatabaseStatus = | |||
| 'active' | |||
| 'degraded' | |||
| 'failed' | |||
| 'migrating' | |||
| 'migrated' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will a database be migrated
?
Does it go from migrating
➡️ migrated
➡️ active
?
Asking because this seems a bit unusual for a Linode product. Usually entities just transition back to active
(or the equivalent to that) when they are done migrating / resizing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnussman-akamai , after a migration is completed, the migrated databases will be left in a read-only state by the tooling and automation that the migration team provides. The special state of the old database is "migrated", while the new database will be "running".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh. I see. So this is for migrating from Legacy to Aiven?
My mistake. I thought this was for migrating a DBaaS cluster between different datacenters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality LGTM, Agreed with @bnussman-akamai it could be consistent with other events unless there is a requirement for the migrated status of databases.
@mpolotsk-akamai Next planned release is 2/11, could you update the release section accordingly ? |
@cpathipa , updated. |
Cloud Manager E2E
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
|
Run duration | 28m 10s |
Commit |
|
Committer | mpolotsk-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
2
|
|
0
|
|
497
|
View all changes introduced in this branch ↗︎ |
Description 📝
DBaaS migrate event notification
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
2/11/25
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
When the migration process starts, the database status will change to "Migrating", and a new event notification will appear under the bell icon indicating that the migration is in progress.
Once the migration is complete, the database status will change to "Migrated", and a new event notification will appear under the bell icon confirming that the migration is completed.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅