test: [M3 8035] - Refactor Marketplace App (OCA) Cypress test #11591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcintyr-akamai
requested review from
carrillo-erik and
abailly-akamai
and removed request for
a team
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/resize-linode.spec.ts" |
|||||||||||||||||
abailly-akamai
approved these changes
Feb 3, 2025
packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts
Outdated
Show resolved
Hide resolved
|
Coverage Report: ✅ |
bnussman-akamai
changed the title
bnussman-akamai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Refactor tests for one-click-apps to improve reliability.
Changes 🔄
List any change(s) relevant to the reviewer.
-"Fix" string input from OCA descriptions by replacing HTML special entities (such as "&") with the html character ("&" in this case). Replacing only the ampersand and registered trademark entities for now, bc those are the only entities used in the descriptions in src/features/OneClickApps/oneClickApps.ts.
How to test 🧪
-yarn cy:run -s "packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts"
Reproduction steps
Tests sporadically fail. The tests in the current develop branch will certainly fail if you hardcode the 2nd and 3rd tests in packages/manager/cypress/e2e/core/oneClickApps/one-click-apps.spec.ts to use a OCA description that has html entities (such as 595742 or 1132204 for an ID).
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅