PSF and attenuation #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @CHrlS98! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-12-16 21:13:49 UTC |
CHrlS98
commented
Dec 16, 2024
linumpy/preproc/icorr.py
Outdated
There was a problem hiding this comment.
Lots of different models here, not all are used. Don't know what we want to do with that.
CHrlS98
commented
Dec 16, 2024
CHrlS98
commented
Dec 16, 2024
CHrlS98
commented
Dec 16, 2024
| @@ -593,6 +594,95 @@ def getAttenuation_Vermeer2013(vol, dz=6.5e-6, mask=None, C=None): | |||
| return mu | |||
|
|
|||
|
|
|||
| def get_extendedAttenuation_Vermeer2013(vol, mask=None, k=10, sigma=5, | |||
There was a problem hiding this comment.
New issue #35 to solve units mismatch issue.
5 tasks
joe-from-mtl
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR compensate psf and attenuation (previously PR #21)