-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DiagID Control packet Handling #11
Open
KyleDengChunkai
wants to merge
2
commits into
linux-msm:master
Choose a base branch
from
KyleDengChunkai:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-clew
suggested changes
Nov 19, 2024
KyleDengChunkai
force-pushed
the
master
branch
3 times, most recently
from
November 25, 2024 09:24
0a585df
to
ca8614f
Compare
quic-clew
suggested changes
Nov 26, 2024
Also can you update the commit message to follow the standard format within the diag project? Commit 1 should be something like:
Second Commit should look like:
|
KyleDengChunkai
force-pushed
the
master
branch
2 times, most recently
from
December 4, 2024 08:20
3df5570
to
e6f5f30
Compare
KyleDengChunkai
force-pushed
the
master
branch
from
December 18, 2024 09:13
e6f5f30
to
122e6b8
Compare
quic-bmanoj
reviewed
Dec 18, 2024
KyleDengChunkai
force-pushed
the
master
branch
from
December 18, 2024 15:17
122e6b8
to
f61ef7e
Compare
quic-clew
suggested changes
Jan 2, 2025
quic-clew
reviewed
Jan 3, 2025
quic-clew
reviewed
Jan 3, 2025
KyleDengChunkai
force-pushed
the
master
branch
3 times, most recently
from
January 7, 2025 08:04
116f8d0
to
8ea2c2d
Compare
Adding support for Diag-ID handshake and storing the information. Diag-ID indicates and indexes the identity of the clients. Signed-off-by: Kyle Deng <[email protected]>
Adding support for the diag-id command response Signed-off-by: Kyle Deng <[email protected]>
KyleDengChunkai
force-pushed
the
master
branch
from
January 9, 2025 09:30
8ea2c2d
to
3b3bea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for DiagID V1, V2 and V3 Control Packet definitions and subsequent feature handling.