Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiagID Control packet Handling #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KyleDengChunkai
Copy link

Add support for DiagID V1, V2 and V3 Control Packet definitions and subsequent feature handling.

router/app_cmds.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.h Outdated Show resolved Hide resolved
@KyleDengChunkai KyleDengChunkai force-pushed the master branch 3 times, most recently from 0a585df to ca8614f Compare November 25, 2024 09:24
router/diag_cntl.h Show resolved Hide resolved
router/diag_cntl.h Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.h Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
@quic-clew
Copy link

Also can you update the commit message to follow the standard format within the diag project? Commit 1 should be something like:

diag_cntl: Add support for diag id v2 and v3 control commands

<description of why its needed and how problem is solved>

signed-off-by<>

Second Commit should look like:

apps_cmds: Add support for get diag ID command

<description of what it is for>

signed-off-by<>

router/diag_cntl.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/app_cmds.c Outdated Show resolved Hide resolved
router/app_cmds.c Show resolved Hide resolved
router/diag.h Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag_cntl.c Outdated Show resolved Hide resolved
router/diag.h Outdated Show resolved Hide resolved
router/diag.h Outdated Show resolved Hide resolved
@KyleDengChunkai KyleDengChunkai force-pushed the master branch 3 times, most recently from 116f8d0 to 8ea2c2d Compare January 7, 2025 08:04
Adding support for Diag-ID handshake and storing the information.
Diag-ID indicates and indexes the identity of the clients.

Signed-off-by: Kyle Deng <[email protected]>
Adding support for the diag-id command response

Signed-off-by: Kyle Deng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants