Prevent interface definitions overriding the 'changed' value while ot…

…her elements are already changed This fixes #234
linux-system-roles · Oct 20, 2024 · 7250f24 · 7250f24
1 parent dd6bdeb
commit 7250f24
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/library/firewall_lib.py b/library/firewall_lib.py
@@ -1468,8 +1468,8 @@ def exception_handler(exception_message):
                 changed = True
             if permanent:
                 nm_used, if_changed = try_set_zone_of_interface(module, zone, item)
-                if nm_used:
-                    changed = if_changed
+                if nm_used and if_changed:
+                    changed = True
                 elif not fw_settings.queryInterface(item):
                     if not module.check_mode:
                         handle_interface_permanent(
@@ -1483,8 +1483,8 @@ def exception_handler(exception_message):
                 changed = True
             if permanent:
                 nm_used, if_changed = try_set_zone_of_interface(module, "", item)
-                if nm_used:
-                    changed = if_changed
+                if nm_used and if_changed:
+                    changed = True
                 elif fw_settings.queryInterface(item):
                     if not module.check_mode:
                         fw_settings.removeInterface(item)