chore: add Rocky Linux vars files #175
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # SPDX-License-Identifier: MIT | ||
| --- | ||
| # Put internal variables here with Rocky Linux 8 specific values. | ||
|
|
||
| __nbde_client_packages: | ||
| - clevis | ||
| - clevis-dracut | ||
| - clevis-luks | ||
| - clevis-systemd | ||
| - iproute | ||
| - NetworkManager | ||
|
|
||
| __nbde_client_initramfs_update_cmd: > | ||
| dracut -fv --regenerate-all | ||
|
|
||
| __nbde_client_dracut_settings: | ||
| - kernel_cmdline+=" rd.neednet=1 " | ||
| - omit_dracutmodules+=" ifcfg " | ||
|
|
||
| __nbde_client_clear_initrd_netcfg_strategy: networkmanager_config | ||
|
|
||
| # vim:set ts=2 sw=2 et: | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # SPDX-License-Identifier: MIT | ||
| --- | ||
| # Put internal variables here with Rocky Linux 9 specific values. | ||
|
|
||
| __nbde_client_packages: | ||
| - clevis | ||
| - clevis-dracut | ||
| - clevis-luks | ||
| - clevis-systemd | ||
| - iproute | ||
| - NetworkManager | ||
|
|
||
| __nbde_client_initramfs_update_cmd: > | ||
|
|
||
| dracut -fv --regenerate-all | ||
|
|
||
| __nbde_client_dracut_settings: | ||
| - kernel_cmdline+=" rd.neednet=1 " | ||
| - omit_dracutmodules+=" ifcfg " | ||
|
|
||
| __nbde_client_clear_initrd_netcfg_strategy: networkmanager_config | ||
|
|
||
| # vim:set ts=2 sw=2 et: | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use
>? You can type__nbde_client_initramfs_update_cmd: dracut -fv --regenerate-allThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I literally just copied the RedHat_8.yml file, renamed it and reworded the comment at the top so that the vars would get pulled in when running against a Rocky Linux system. The Alma and CentOS vars files are also identical (outside the comment) to the RedHat ones, so it may even make sense to add a check in set_vars.yml for
{{ ansible_facts['os_family'] }}_{{ ansible_facts['distribution_major_version'] }}.ymland do away with the seperate files for each EL flavor. Not sure which would be prefered.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several problems with using
os_familylike thisRedHatthe distribution vs.RedHatthe os_family?RedHatos_family but has a very different versioning schemeRedHatfamily that do not follow the versioning scheme followed by RedHat, CentOS, Rocky, Alma, and OracleIt would be great if there were an Ansible category somewhere between os_family and distribution -
os_clone_alikes? - that were version sync compatible - that way you could say RedHatClones_8 and be very sure that you mean RedHat and very close version clones, and not things like Fedora, ScientificLinux, etc. which are part of RedHat family.Of course, in practice, these roles will almost never be used on anything except Fedora and strict clones of RedHat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, I wasn't aware some of those other OSes still fell under the RedHat os family. Back to the original comment then, would it be better to move those to the single line as you suggested, or keep as is for consistency with the other RedHat-derived vars files?