refactor admin server desing #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimir-d
previously approved these changes
Jul 29, 2022
| @@ -56,7 +57,7 @@ func toMongoQuery(query storage.Query) bson.D { | |||
|
|
|||
| if query.Text != nil { | |||
| q = append(q, bson.E{ | |||
| Key: "logdata", | |||
| Key: "log_data", | |||
There was a problem hiding this comment.
note that this is a breaking change, youre changing a db field and consumers may already be using the last version of the field names in their mongo deployments
i will approve this this time, as the project state is technically "not launched", but you should consider a migration mechanism for these updates
There was a problem hiding this comment.
you might want to consider a db migration/versioning scheme later on to address this
mahmednabil109
force-pushed
the
Refactor_admin_server_design
branch
2 times, most recently
from
b943f49 to
6c3d05f
Compare
mimir-d
reviewed
Aug 1, 2022
- separate storage entities from server entities Signed-off-by: Mohamed Abokammer <[email protected]>
mahmednabil109
force-pushed
the
Refactor_admin_server_design
branch
from
6c3d05f to
5e259ce
Compare
mimir-d
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohamed Abokammer [email protected]