Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check psng_hook return value for error conditions #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiall
Copy link
Contributor

@kiall kiall commented Dec 27, 2020

Any return value less than 0 will be treated as a failure, and will abort
the remainder of the macro execution.

Any return value less than 0 will be treated as a failure, and will abort
the remainder of the macro execution.
@alkabal
Copy link
Contributor

alkabal commented Dec 27, 2020

Imo this can be done directly in hook
I see hook like a safe check and this one need to manage all possible situation and choose to abort herself if needed

using (abort,blabla) in hook seem to work fine for stopping all the process, but I can verify that this evening

@alkabal
Copy link
Contributor

alkabal commented Dec 27, 2020

The things I think that need enhanced is using stop button from GUI regardless to pause condition or in movement need to cancel the whole operation and not only a part of the next operation

@alkabal
Copy link
Contributor

alkabal commented Dec 27, 2020

Maybe add this inside hook as example seem to be enough :

o10 if [#<hooked_macro> GT 9]
(ABORT, HOOK UNRECOGNIZED : #<hooked_macro>)
o10 endif

@alkabal
Copy link
Contributor

alkabal commented Dec 27, 2020

psng_hook.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants