Set system to configuration base units before any moves or probes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andypugh <[email protected]>
|
HiThanks for the patch but Unfortunately this repo seem to be dead.I have try to work on something more advanced like adding some leveling optionprevent colision wirh tool setterAllowing to swap from touch plate to 3d probeAuto Z machine limitalkabal/PSNG_V3github.comBrLe 8 mai 2023 à 13:39, andypugh ***@***.***> a écrit :Based on a LinuxCNC forum thread where the user had been machining in G20 mode on a metric config, then tried to re-probe a tool. https://forum.linuxcnc.org/38-general-linuxcnc-questions/48184-probe-screen-v2-python-file-not-open-errors#264082
You can view, comment on, or merge this pull request online at:
#77
Commit Summary
a6fb0d2 Set system to configuration base units before any moves or probes
File Changes (5 files)
M
psng/python/base.py
(12)
M
psng/python/length_measurement.py
(41)
M
psng/python/rotation.py
(40)
M
psng/python/tool_measurement.py
(21)
M
psng/python/workpiece_measurement.py
(116)
Patch Links:
https://github.com/linuxcnc-probe-screen/probe-screen-ng/pull/77.patch
https://github.com/linuxcnc-probe-screen/probe-screen-ng/pull/77.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
It probably is, but making the pull request seemed worth a try. |
|
Thank youI don’t know if my revision have the same problem, I have so much diverges from the old repo.In my opinion my attempt is much advanced and is close to be fully functional.Best regards Le 10 mai 2023 à 18:50, andypugh ***@***.***> a écrit :
HiThanks for the patch but Unfortunately this repo seem to be dead.
It probably is, but making the pull request seemed worth a try.
The fixed version can be downloaded from my fork of the repo:
https://github.com/andypugh/probe-screen-ng
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a LinuxCNC forum thread where the user had been machining in G20 mode on a metric config, then tried to re-probe a tool. https://forum.linuxcnc.org/38-general-linuxcnc-questions/48184-probe-screen-v2-python-file-not-open-errors#264082