Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong open image icon and wrong live text shortcut #171

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented Jul 17, 2024

fix: wrong open image icon component

Replace DciIcon to ActionButton.

Log: fix wrong open image icon component
Bug: https://pms.uniontech.com/bug-view-206551.html,
https://pms.uniontech.com/bug-view-185445.html

fix: can't copy live text with shortcut

Fixed the conflict between text copy and image copy
shortcut keys;
Manually disconnect, fix the liveblock warning after
destroy().

Log: fix live text shortcut.
Bug: https://pms.uniontech.com/bug-view-219989.html

fix: rename dialog layout

rename dialog layout

Log: rename dialog layout
Bug: https://pms.uniontech.com/bug-view-167969.html,
https://pms.uniontech.com/bug-view-168641.html

fix: wrong text translation

update text translation.

Log: Update text translation.
Bug: https://pms.uniontech.com/bug-view-165223.html,
https://pms.uniontech.com/bug-view-216901.html

rb-union added 5 commits July 17, 2024 17:06
Use qml register replace context property,
and new function connection.

Log: fix some warning output
Fixed the conflict between text copy and image copy
shortcut keys;
Manually disconnect, fix the liveblock warning after
destroy().

Log: fix live text shortcut.
Bug: https://pms.uniontech.com/bug-view-219989.html
@deepin-ci-robot
Copy link

deepin pr auto review

Fix translation for Chinese, Traditional Chinese, and English

@pengfeixx
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit a21be3e into linuxdeepin:master Jul 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants