Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation not update while image rotate #180

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

rb-union
Copy link
Contributor

fix navigation not update while image rotate.

Log: fix navigation not update while image rotate.
Influence: Animation

fix navigation not update while image rotate.

Log: fix navigation not update while image rotate.
Influence: Animation
as title.

Log: fix right menu delete not work.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • updateMask函数中,应该检查currentImage.widthcurrentImage.height是否有效,以避免潜在的除以零错误或未定义行为。
  • updateSource函数中的source变量应该使用const关键字修饰,以避免意外修改。
  • onCurrentFrameIndexChangedonCurrentRotationChanged函数中,应该避免在每次更改时都重新设置source,这可能会导致性能问题。
  • onCurrentSourceChanged函数在ViewRightMenu.qml中为空,如果这是有意为之,应该添加注释说明原因。
  • rotateImageFile函数中,注释中的“逻辑有问题”应该详细说明问题所在,以便其他开发者理解需要修复的特定问题。
  • rotateImageFile函数中的// TODO注释应该被解决或被删除,以保持代码的完整性和可维护性。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@rb-union rb-union merged commit 0fd6e7f into linuxdeepin:master Aug 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants