Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move show shortcut panel to mainwindow #190

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

rb-union
Copy link
Contributor

as title.
Enable pop-up shortcut panel on main window.

Log: Fix shortcut issue.
Bug: https://pms.uniontech.com/bug-view-273543.html

as title.
Enable pop-up shortcut panel on main window.

Log: Fix shortcut issue.
Bug: https://pms.uniontech.com/bug-view-273543.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Shortcut元素中,sequence属性应该是一个字符串数组,而不是一个字符串。
  • IV.FileControl.showShortcutPanel函数调用中的参数screenPos.x + parent.Window.width / 2screenPos.y + parent.Window.height / 2可能会导致坐标计算错误,因为mapToGlobal返回的是一个Point对象,而不是一个坐标值。
  • 缺少对Shortcut元素在某些条件下的禁用或启用,可能会导致用户在不适用快捷键的情况下也能看到快捷面板。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit 4f4e286 into linuxdeepin:master Sep 13, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants