Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复漏洞 【CITIVD】Deepin-image-viewer-缓冲区溢出 #139

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Jun 17, 2024

修复漏洞 【CITIVD】Deepin-image-viewer-缓冲区溢出

Bug: https://pms.uniontech.com/bug-view-259819.html
Log: 修复漏洞 【CITIVD】Deepin-image-viewer-缓冲区溢出

修复漏洞 【CITIVD】Deepin-image-viewer-缓冲区溢出

Bug: https://pms.uniontech.com/bug-view-259819.html
Log: 修复漏洞 【CITIVD】Deepin-image-viewer-缓冲区溢出
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • readFile2FIBITMAP函数中新增了对QImage对象是否有效的检查,这是一个好的做法,可以避免在后续处理无效图片时出现错误。

是否建议立即修改:

  • 否,当前提交的代码没有明显的语法错误或逻辑问题。
  • 是,建议添加一些注释来解释为什么要进行isNull检查,以及这个检查的具体含义。
  • 是,如果FIBITMAP的内存分配是一个资源密集型的操作,建议在检查图片有效性的同时,对内存使用进行优化,以避免可能的内存泄漏。

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Copy link
Contributor

@starhcq starhcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 591a23f into linuxdeepin:master Jun 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants