Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary dirs are created by default #142

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

rb-union
Copy link
Contributor

Modify not to automatically create temporary directories.

  • AIModelServiceData should not be created, but not fully tested.

Log: Not create temporary dirs by default

Modify not to automatically create temporary directories.
* AIModelServiceData should not be created, but not fully
  tested.

Log: Not create temporary dirs by default
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • AIModelServiceData::AIModelServiceData构造函数中,enhanceTemp的初始化应该在supportNameToModel.isEmpty()条件之外,以避免在没有模型数据时创建临时目录。
  • convertTemp的初始化也应该在isValid()条件之外,以确保在AIModelService实例无效时不会尝试创建临时目录。
  • enhanceTempconvertTemp的类型从QTemporaryDir更改为QScopedPointer<QTemporaryDir>,这是一个好的做法,因为它确保了临时目录在不再需要时会被正确地清理。
  • isTemporaryFile方法的修改确保只有在AIModelService实例有效时才会检查文件是否是临时文件。
  • checkConvertFile方法的修改也做了类似的事情,只有在AIModelService实例有效时才会检查文件路径是否是临时文件。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@rb-union rb-union merged commit 3e31964 into linuxdeepin:master Jul 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants