multiple deployers: Ignore .debug files #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After having merged #175, this needs to be rebased most likely but on the other hand, it'll greatly simplify this contribution. |
|
Happy to rebase atop the new structure. |
|
@tdewey-rpi please rebase. |
tdewey-rpi
force-pushed
the
ignore-debug-files
branch
from
29bcebd to
1e1f146
Compare
bjorn
approved these changes
Aug 23, 2024
For the sake of a clean history, I'll run add this to the PR. |
bjorn
approved these changes
Sep 3, 2024
TheAssassin
force-pushed
the
ignore-debug-files
branch
from
ab90df8 to
716edc6
Compare
TheAssassin
approved these changes
Dec 23, 2024
|
I think there would be some value in making this configurable, but we can add that as soon as someone requires such a feature. |
This commit replicates a pattern from the TextToSpeechPluginsDeployer into the BasicPluginsDeployer - to affect all standard deployers. Essentially - it's extremely unlikely that composing an AppImage with debug symbols is what a user actually wants to do. I'm also not aware of a good story for connecting debug symbols to an AppImage at all. As a result, let's make a sensible choice - and not package them. Trust that developers will use their underlying build system for Debug, and that release tracking will allow developers to tie an AppImage back to a source control revision. Finally, note that this works around an interesting aarch64 bug - where the .debug files that are created are marked as x86_64 ELF binaries - even when you are _building on an aarch64 host_.
With the refactor of BasicPluginsDeployer, we can collapse the contents of the TextToSpeechPluginsDeployer to just a call into the base class, with the appropriate argument.
TheAssassin
force-pushed
the
ignore-debug-files
branch
from
716edc6 to
524f7b7
Compare
|
Thanks for your contribution @tdewey-rpi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replicates a pattern from the TextToSpeechPluginsDeployer across a range of other deployer classes.
Essentially - it's extremely unlikely that composing an AppImage with debug symbols is what a user actually wants to do. I'm also not aware of a good story for connecting debug symbols to an AppImage at all.
As a result, let's make a sensible choice - and not package them. Trust that developers will use their underlying build system for Debug, and that release tracking will allow developers to tie an AppImage back to a source control revision.
Finally, note that this works around an interesting aarch64 bug - where the .debug files that are created are marked as x86_64 ELF binaries - even when you are building on an aarch64 host.
Fixes: #110, but not in the manner suggested by the first respondent as they have conflated a desire to remove the .debug objects with a desire to remove text objects.