Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New speakers block #925

Merged
merged 61 commits into from
Sep 10, 2024
Merged

New speakers block #925

merged 61 commits into from
Sep 10, 2024

Conversation

cjyabraham
Copy link
Collaborator

@cjyabraham cjyabraham commented Jul 17, 2024 •
edited
Loading

Addresses the following issues: #745, #929, #129, #933, #934, #935

Dev instance showing the new block

On deploy:

  • Activate the new plugin for Speakers Block 2
  • Set speaker generic image in the settings

@cjyabraham cjyabraham marked this pull request as draft July 17, 2024 08:16
@cjyabraham
Added new speaker fields
a0340df 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
Add help text
64851b9 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
Moved CNCF people design in to new speaker block
c3b02c7 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
Get the modal working
21fa7cb 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
got the company logo showing
0dd497d 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
got the close image to show
e633646 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
respect block width setting
aefd8f6 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
open social links in new tabs to be consistent with lfevents conventions
30eed48 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
Fix social hover colors
c5b4f2a 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
tweak designs
443d14d 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
update comments
0c65dee 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
amp up the name
af2379f 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
remove social links on tile
79cea08 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
got the tiles looking good
dc4b262 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
fixed image in modal
37a7112 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
get things centered
9eb5289 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
fix modal on mobile
9ad8eac 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
style tweaks
453326a 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
fix image margin
a72f08c 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
Fix image alt text
276f7db 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
Add sched data bits
27bf88a 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham cjyabraham mentioned this pull request Aug 16, 2024
Closed
cjyabraham and others added 17 commits August 21, 2024 11:00
@cjyabraham
Move timestamp update outside of loops
eac8715 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
fixed hardcoded event id
dd6ff82 
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham
fixed update_post_meta command which automatically strips slashes
e8cabab 
Signed-off-by: Chris Abraham <[email protected]>
@thetwopct
#934 Removing hardcoded LMFP URL
c9c1444 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Rename, refactor, optimise
001cb49 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
#935 fix npm run dev to keep watching files
c8d2c02 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Add generic speaker image
b9a3e49 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Update PHPCS to include SB2
1b9f089 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Improve accessibility of menu, #673
0f21a3b 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Improve display of outlines site-wide, #673
ecfc327 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Additional accessibility improvements, #637
8e806bf 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Update Speakers Block design
cab1978 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Improving Admin screen for Speakers
547b12c 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Style Tweaks
054cf92 
Signed-off-by: James Hunt <[email protected]>
@cjyabraham
Darken the background a touch
86be553 
Signed-off-by: Chris Abraham <[email protected]>
@thetwopct
Updates to speakers block 2
c07e463 
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Block makes use of event Sched ID
3123956 
Signed-off-by: James Hunt <[email protected]>
@cjyabraham cjyabraham merged commit b8c6aee into main Sep 10, 2024
6 checks passed
@cjyabraham cjyabraham deleted the new-speakers branch September 10, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetwopct thetwopct thetwopct left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjyabraham @thetwopct