Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and add SVG support #1222

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Fix and add SVG support #1222

merged 1 commit into from
Nov 11, 2023

Conversation

fyutins
Copy link
Contributor

@fyutins fyutins commented Sep 26, 2023

SVG images were not supported because the function getimagesize does not work with SVG.

Should resolve #1179

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

@SirSKillz SirSKillz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't actually run this but I can apparently approve and I want this fix to be merged in already

Copy link

@ElDubsNZ ElDubsNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend approving as this should fix the issue.

Copy link
Member

@KodeStar KodeStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, I’d rather not just ignore any errors, but it shouldn’t be a big issue

@KodeStar KodeStar merged commit 768e7a6 into linuxserver:2.x Nov 11, 2023
4 checks passed
@fweep
Copy link

fweep commented Nov 11, 2023

I'm not sure if this was intentional, or if it really matters to anyone else, but this release is tagged V2.5.8 with a capital V, unlike all previous releases, which use a lowercase v (e.g. v2.5.7).

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Error "Icon must be an image." when attempting to create some appliction Launcers
7 participants