Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GleSYS DNS plugin #425

Merged
merged 35 commits into from
Jan 9, 2024
Merged

Add GleSYS DNS plugin #425

merged 35 commits into from
Jan 9, 2024

Conversation

Peglah
Copy link
Contributor

@Peglah Peglah commented Nov 8, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This change adds the certbot-dns-glesys python module to the container, allowing for certbot dns verification to be done using the GleSYS DNS API.

Benefits of this PR and context:

This change provides an additional DNS verification mechanism, meaning that users of GleSYS are able to use DNS verification for certbot on the SWAG instances.

How Has This Been Tested?

I have tested this change by building the project locally and running one of my swag instances with the updates docker image and GleSYS DNS configuration. The swag instance was successfully able to generate new certbot certificates (covering 1 sub domains) using GleSYS DNS.

Source / References:

docker-swag.log

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.7.4-pkg-f440af71-dev-278b57fb4785ce44fbba6ab841342e4920132711-pr-425/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.7.4-pkg-f440af71-dev-278b57fb4785ce44fbba6ab841342e4920132711-pr-425/shellcheck-result.xml

Tag Passed
amd64-2.7.4-pkg-f440af71-dev-278b57fb4785ce44fbba6ab841342e4920132711-pr-425
arm64v8-2.7.4-pkg-f440af71-dev-278b57fb4785ce44fbba6ab841342e4920132711-pr-425

@nemchik
Copy link
Member

nemchik commented Nov 11, 2023

This addition will depend on the outcome of #422

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@brother
Copy link

brother commented Dec 11, 2023

I consider it active still. We’re waiting on the linked issue.

@Peglah
Copy link
Contributor Author

Peglah commented Jan 1, 2024

Since #422 now is closed I tried to rebase this PR. I'm still learning git however...
Anyway, I tried the rebased code and it still works as expected. Here is a log.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.8.0-pkg-6d4768cc-dev-9693b5884fbdbc2936d6ab475e19d7c5bfd8d53a-pr-425/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.8.0-pkg-6d4768cc-dev-9693b5884fbdbc2936d6ab475e19d7c5bfd8d53a-pr-425/shellcheck-result.xml

Tag Passed
amd64-2.8.0-pkg-6d4768cc-dev-9693b5884fbdbc2936d6ab475e19d7c5bfd8d53a-pr-425
arm64v8-2.8.0-pkg-6d4768cc-dev-9693b5884fbdbc2936d6ab475e19d7c5bfd8d53a-pr-425

Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Note for team visibility: I compared the package versions from the PR to master and nothing is downgrading.

@nemchik nemchik merged commit ffb03a0 into linuxserver:master Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants