-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GleSYS DNS plugin #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
This addition will depend on the outcome of #422 |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
I consider it active still. We’re waiting on the linked issue. |
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: Eric Nemchik <[email protected]>
Fixes regression from #399 Signed-off-by: Eric Nemchik <[email protected]>
Signed-off-by: GitHub <[email protected]>
Since #422 now is closed I tried to rebase this PR. I'm still learning git however... |
I am a bot, here are the test results for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Note for team visibility: I compared the package versions from the PR to master and nothing is downgrading.
Description:
This change adds the certbot-dns-glesys python module to the container, allowing for certbot dns verification to be done using the GleSYS DNS API.
Benefits of this PR and context:
This change provides an additional DNS verification mechanism, meaning that users of GleSYS are able to use DNS verification for certbot on the SWAG instances.
How Has This Been Tested?
I have tested this change by building the project locally and running one of my swag instances with the updates docker image and GleSYS DNS configuration. The swag instance was successfully able to generate new certbot certificates (covering 1 sub domains) using GleSYS DNS.
Source / References:
docker-swag.log