Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of INSERT statements #394

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

strk
Copy link
Contributor

@strk strk commented Mar 24, 2020

I was just annoyed by the many INSERT reports printed back
upon running make check. Not sure this is the actual source
or this is a file generated by sqitch or something, let me know :)

@ghost ghost added pr: not closing issue pr-esto adds when no linked issue to close. pr: no changelog pr-esto adds when CHANGELOG not updated. pr: no reviewer pr-esto adds when no reviewer found. labels Mar 24, 2020
@strk
Copy link
Contributor Author

strk commented Mar 24, 2020

I would reduce more INSERT statements in other files, but if they are generated it'd be a waste of time to tweak them so please let me know (@dwsilk ?).

Many such "offending" files are under db/tests/testdata/db:

db/tests/testdata/db$ grep -ic INSERT *
admin_bdys.sql:8
aerial_lds.sql:2
buildings_bulk_load.sql:494
buildings_common.sql:2
buildings_lds.sql:143
buildings_reference.sql:21
buildings.sql:292
update_sequences.sql:0

@dwsilk
Copy link
Member

dwsilk commented Mar 24, 2020

That will certainly clean things up quite a bit :-)

The only thing I can think of is that this script might also need to be adjusted to align with this change: https://github.com/linz/nz-buildings/blob/master/db/scripts/dump_schema.sh

@dwsilk
Copy link
Member

dwsilk commented Mar 24, 2020

Also I can now see that our GitHub Actions checks don't work on PRs from forks. We should fix that too.

@bencheng1990 bencheng1990 added this to the Sprint 73 milestone Mar 24, 2020
@ghost ghost added pr: review requested pr-esto adds when a review is requested. and removed pr: no reviewer pr-esto adds when no reviewer found. labels Mar 24, 2020
@bencheng1990 bencheng1990 modified the milestones: Sprint 73, Sprint 74 Apr 7, 2020
@katebazeley katebazeley modified the milestones: Sprint 74, Sprint 75 Apr 21, 2020
@katebazeley katebazeley removed this from the Sprint 75 milestone May 5, 2020
@MDavidson17 MDavidson17 removed their request for review September 27, 2020 20:06
@ghost ghost added pr: no reviewer pr-esto adds when no reviewer found. and removed pr: review requested pr-esto adds when a review is requested. labels Sep 27, 2020
@strk
Copy link
Contributor Author

strk commented Nov 3, 2020

@dwsilk is that script used to generate those files ? If so... should those files NOT be in the git repository at all ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: no changelog pr-esto adds when CHANGELOG not updated. pr: no reviewer pr-esto adds when no reviewer found. pr: not closing issue pr-esto adds when no linked issue to close.
Development

Successfully merging this pull request may close these issues.

4 participants