-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of INSERT statements #394
base: master
Are you sure you want to change the base?
Conversation
I would reduce more INSERT statements in other files, but if they are generated it'd be a waste of time to tweak them so please let me know (@dwsilk ?). Many such "offending" files are under
|
That will certainly clean things up quite a bit :-) The only thing I can think of is that this script might also need to be adjusted to align with this change: https://github.com/linz/nz-buildings/blob/master/db/scripts/dump_schema.sh |
Also I can now see that our GitHub Actions checks don't work on PRs from forks. We should fix that too. |
@dwsilk is that script used to generate those files ? If so... should those files NOT be in the git repository at all ? |
I was just annoyed by the many INSERT reports printed back
upon running
make check
. Not sure this is the actual sourceor this is a file generated by sqitch or something, let me know :)