[EVPN] Skip EVPN routes with invalid VNI or router mac field #3054 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Skip EVPN routes with invalid VNI or router mac field
Why I did it
Code assumes number of next hops is equal to amount of VNIs and to amount of router macs.
Usually this is this the case however, we encountered a case of inequality due to bug in FRR.
Bug was opened to FRR but the code should not assume equality therefore I added the check.
How I verified it
I ran EVPN test with code that enforced different vector length, and made sure error is printed to log and route is skipped.
Details if related