[7942] euth, euth_wagtail: fix styling for login #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4ra
force-pushed
the
mk-2024-01-18-fix-dropdown-login
branch
from
2e68856 to
ac56afa
Compare
|
@hom3mad3 once this is merged I can initiate the release process. |
|
@hom3mad3 can you have a look when possible, I would like to work on the OPIN release after that. |
hom3mad3
requested changes
Jan 22, 2024
| </li> | ||
| --> | ||
| </ul> | ||
| </ul> |
There was a problem hiding this comment.
- the last
</ul>is closing the list tag that starts at the beginning --><ul class="nav navbar-nav navbar-right ...> - the line 4 class dropdown is needed for when we have logged in, see the if statement that indicates
if user.is_authenticated
There was a problem hiding this comment.
uhm.. you are right, we don't need the extra closing
m4ra
force-pushed
the
mk-2024-01-18-fix-dropdown-login
branch
from
ac56afa to
b27d1e4
Compare
hom3mad3
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2676