Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forms shouldn't use browser validation but our own error messages. #2572

Merged
merged 1 commit into from
Apr 18, 2024
Merged

forms shouldn't use browser validation but our own error messages. #2572

merged 1 commit into from
Apr 18, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Apr 17, 2024

see liqd/a4-meinberlin@e1aecba

fixes #2571

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk requested a review from m4ra April 17, 2024 15:13
m4ra
m4ra approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@m4ra m4ra merged commit 51fb9b9 into main Apr 18, 2024
3 checks passed
@m4ra m4ra deleted the jd-2024-04-ckeditor-form-validation branch April 18, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4ra m4ra m4ra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#7637 [a+] big django & wagtail update: Submission of (Map-) Ideas and Proposals does not work
2 participants
@goapunk @m4ra