fix: Move lqty allocation checks #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As value now encodes timestamp, it would never be zero, we need to decode and then check.
src/BribeInitiative.sol
Outdated
| && (totalLQTYAllocation.next > _epoch || totalLQTYAllocation.next == 0), | ||
| "BribeInitiative: invalid-prev-total-lqty-allocation-epoch" | ||
| ); | ||
|
|
||
| (uint88 totalLQTY, uint120 totalAverageTimestamp) = _decodeLQTYAllocation(totalLQTYAllocation.value); | ||
| require(totalLQTY > 0, "BribeInitiative: invalid-prev-total-lqty"); |
There was a problem hiding this comment.
I would rephrase the error message. The variable being checked stands for the total LQTY allocated to the initiative in the epoch from which the bribes are being claimed from. Thus, I guess a better message would be: invalid-total-lqty-allocation or total-lqty-allocation-zero.
src/BribeInitiative.sol
Outdated
| @@ -113,6 +113,7 @@ contract BribeInitiative is IInitiative, IBribeInitiative { | |||
| uint240 totalVotes = governance.lqtyToVotes(totalLQTY, scaledEpochEnd, totalAverageTimestamp); | |||
| if (totalVotes != 0) { | |||
| (uint88 lqty, uint120 averageTimestamp) = _decodeLQTYAllocation(lqtyAllocation.value); | |||
| require(lqty > 0, "BribeInitiative: invalid-prev-lqty"); | |||
danielattilasimon
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As value now encodes timestamp, it would never be zero, we need to decode and then check.