-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts: move to pnpm #88
Merged
+6,987
−6,915
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c6f4480
Contracts: move to pnpm
bpierre 04e537c
Workflow: pnpm version
bpierre ab6da74
Merge branch 'main' into contracts-pnpm
bpierre 6f737a9
Add .node-version
bpierre 04a670c
Add cache-dependency-path (needed since we don’t have a top level pac…
bpierre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,20 +73,28 @@ jobs: | |
with: | ||
submodules: recursive | ||
|
||
- uses: actions/setup-node@v3 | ||
- name: Install pnpm | ||
uses: pnpm/[email protected] | ||
with: | ||
node-version: 20 | ||
version: 8 | ||
|
||
- name: Install Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version-file: '.node-version' | ||
cache: 'pnpm' | ||
cache-dependency-path: 'contracts/pnpm-lock.yaml' | ||
|
||
- name: Install dependencies | ||
run: yarn install --frozen-lockfile | ||
run: pnpm install | ||
|
||
- name: Install Foundry | ||
uses: foundry-rs/foundry-toolchain@v1 | ||
with: | ||
version: nightly | ||
|
||
- name: Test contracts | ||
run: yarn test | ||
run: pnpm test | ||
|
||
coverage: | ||
name: Coverage | ||
|
@@ -125,20 +133,22 @@ jobs: | |
# id: coverage_filter | ||
|
||
# Hardhat | ||
- uses: actions/setup-node@v3 | ||
- name: Install pnpm | ||
uses: pnpm/[email protected] | ||
with: | ||
node-version: 20 | ||
cache: yarn | ||
cache-dependency-path: "./contracts/yarn.lock" | ||
env: | ||
# Workaround for https://github.com/actions/setup-node/issues/317 | ||
FORCE_COLOR: 0 | ||
version: 8 | ||
|
||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version-file: '.node-version' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The CI is complaining about this. I guess we need to create that file? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes I added it 👍 |
||
cache: 'pnpm' | ||
cache-dependency-path: 'contracts/pnpm-lock.yaml' | ||
|
||
- name: Install dependencies | ||
run: yarn install --frozen-lockfile | ||
run: pnpm install | ||
|
||
- name: harhdat coverage | ||
run: yarn coverage | ||
run: pnpm coverage | ||
continue-on-error: true | ||
env: | ||
NODE_OPTIONS: --max-old-space-size=4096 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
20 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also moved to the latest version of
actions/setup-node
(v3 => v4)