-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format Solidity + JS + TS files, pnpm workspace #97
Conversation
Could we move the formatting into the root of the repo? I know this requires one more Also, the dprint plugin for VS Code only works if the config file is in the root directory. |
Good point yes! I am wondering: would it make sense to move to a monorepo now that we have moved to pnpm? From my experience doing this with pnpm after yarn:
I think the only change needed would be to add a |
It occured to me too. We should give it a try with pnpm workspaces. The reason I swore off of using a monorepo again was mostly because of Yarn and the nightmare that is package hoisting. Thankfully, pnpm does none of that crap. |
I added the change to the PR 🔥 |
Now that we have a workspace in the root of the repo, we also have node_modules there.
The default is 120.
"json": { | ||
}, | ||
"markdown": { | ||
"arrowFunction.useParentheses": "force" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I thought this one would be nice to have for consistency. I also removed useBraces: "always"
compared to what we had on frontend/
, to be a bit less strict. Also no strong opinion about these two, what do you think @danielattilasimon?
The format script is to be ran before merging this PR, whenever we are ready.