Ensure ErrorResponse is cleared between PollForErrorResponse runs

lirm · Mar 6, 2024 · 427477a · 427477a
1 parent c03ed22
commit 427477a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/archive/control.go b/archive/control.go
@@ -349,6 +349,8 @@ func (control *Control) PollForErrorResponse() (int, error) {
 	context := PollContext{control, 0}
 	received := 0
 
+	control.Results.ErrorResponse = nil
+
 	// Poll for async events, errors etc until the queue is drained
 	for {
 		ret := control.poll(

diff --git a/archive/control_test.go b/archive/control_test.go
@@ -127,7 +127,6 @@ func TestControl_PollForErrorResponse(t *testing.T) {
 		cnt, err := control.PollForErrorResponse()
 		assert.EqualValues(t, 1, cnt)
 		assert.Error(t, err)
-		control.Results.ErrorResponse = nil // TODO: Should this really be necessary?
 		cnt, err = control.PollForErrorResponse()
 		assert.EqualValues(t, 1, cnt)
 		assert.NoError(t, err)