Use ControlledPoll for PollForResponse and PollForErrorResponse #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers the basic behavior of consuming responses. Arguably, they do a lot more as they e.g. dispatch recording signals and whatnot, but this is a start.
The idea here is that we want to reimplement the PollForResponse methods using ControlledPoll, without having to update the tests.
This iteration just returns action continue on the top level everywhere, so this shouldn't really have any impact so far.
This updates the code to poll for up to 10 fragments at once, but we use the controlled poll as a mechanism to ensure we are not committing to more messages than what is needed.
grddev
force-pushed
the
limit-response-poll
branch
from
6fafc74 to
4ef3a85
Compare
ethanf
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PollForResponse consumed responses after the response it was looking for in the incoming response stream, which specifically made it impossible to poll for replication initialization errors when setting up a replication, as they were consumed by the PollForResponse inside the Replicate operation.
This also updated PollForErrorResponse to reset the error between polls, or else it would just immediately return the previous error.
This also adds some tests for the two methods. The tests are nowhere near complete, but should give some coverage for the changes implemented here.